-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for tests to run in pre-created NS #234
Conversation
3b2d552
to
42cfb1a
Compare
* allows for running tests in pre-created * allows for running tests as a regular user (project admin) as long as the namespaces and RBAC are created in advance by cluster admin
42cfb1a
to
fbb2b50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mgencur, pierDipi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mgencur: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This Pull Request is stale because it has been open for 90 days with |
@mgencur: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@mgencur are you still interested in this PR? |
@pierDipi No. Let me close it. If we need it again I can create a new one but it's unlikely. |
Changes
This builds upon #233 . I'm including the commits from that PR here as well and will remove them later when/if the other PR is merged
I tried running the rekt tests from knative/eventing with pre-created namespaces and this flag by a project admin user. The result is:
The failures are related to several individual tests which require clusterrole creation. These tests will need to be excluded from the execution.
/kind enhancement
Fixes #192
Release Note
Docs