Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly shutdown tracer to flush Spans #376

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Aug 17, 2022

This is a follow-up on knative/pkg#2566.

Changes

  • Get a reference to Tracer and call the Shutdown function on it when finishing work. This will flush buffered Spans to Zipkin.

Release Note


Docs


@knative-prow
Copy link

knative-prow bot commented Aug 17, 2022

@mgencur: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

This is a follow-up on knative/pkg#2566.

Changes

  • Get a reference to Tracer and call the Shutdown function on it when finishing work. This will flush buffered Spans to Zipkin.

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 17, 2022
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2022
@knative-prow knative-prow bot merged commit 89e41db into knative-extensions:main Aug 17, 2022
@mgencur
Copy link
Contributor Author

mgencur commented Aug 18, 2022

@matzew Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants