Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Add pierDipi to approvers #1610

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Conversation

pierDipi
Copy link
Member

related: knative/eventing#4095

discussion: #795

Proposed Changes

  • Add pierDipi to approvers

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 25, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 25, 2020
@pierDipi
Copy link
Member Author

/cc @matzew

@matzew
Copy link
Member

matzew commented Sep 29, 2020

/lgtm
/assign @lionelvillard

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
@lionelvillard
Copy link
Member

/approve

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
@aliok
Copy link
Member

aliok commented Sep 30, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, lionelvillard, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aliok,lionelvillard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2020
@knative-prow-robot knative-prow-robot merged commit 6ce6213 into knative:master Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants