New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestReply: Add CESQL function #8360

Open

d3akhtar wants to merge 3 commits into knative:main from d3akhtar:correlation-id-cesql-user-function

d3akhtar commented Dec 1, 2024

Fixes #8318

Proposed Changes

Added correlation ID filter that creates a user-defined CESQL function, then returns a CESQL filter
Added tests for correlation ID filter

Pre-review Checklist

At least 80% unit test coverage
E2E tests for any new behavior
Docs PR for any user-facing impact
Spec PR for any new API feature
Conformance test for any change to the spec

Release Note

Added CESQL user function to validate correlation ID

Docs


          RequestReply: Add CESQL function (knative#8318)

16053ce

linux-foundation-easycla bot commented Dec 1, 2024 •

edited

Loading

The committers listed above are authorized under a signed CLA.

✅ login: d3akhtar (3a4c452, 16053ce, 5725c03)

knative-prow bot commented Dec 1, 2024

Welcome @d3akhtar! It looks like this is your first PR to knative/eventing 🎉

knative-prow bot commented Dec 1, 2024

Hi @d3akhtar. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow bot added needs-ok-to-test size/L labels

knative-prow bot requested review from creydr and matzew

December 1, 2024 19:54

Member

Cali0707 commented Dec 1, 2024

/ok-to-test

knative-prow bot added ok-to-test and removed needs-ok-to-test labels

Cali0707 reviewed

View reviewed changes

Member

Cali0707 left a comment

Great start @d3akhtar ! I left a few initial review comments, but since we worked on it together hopefully @pierDipi or @creydr can take a closer look as well

/cc @pierDipi @creydr

pkg/eventfilter/subscriptionsapi/cesql_correlationid_filter.go

+              				return false, errors.New("correlationId Format: <original id>:<base64/hex encoded encrypted id>")
+              			}
+              			slice := strings.Split(correlationId, ":")

Member

Cali0707 Dec 1, 2024

For the split here, do we need to consider that : may be a part of the id itself? Is there a need for this to be configurable? cc @pierDipi @creydr

pkg/eventfilter/subscriptionsapi/cesql_correlationid_filter.go Outdated Show resolved Hide resolved

pkg/eventfilter/subscriptionsapi/cesql_correlationid_filter.go

+              		},
+              	)
+              	ceruntime.AddFunction(correlationIdFilterFunction)

Member

Cali0707 Dec 1, 2024

I might add this to the runtime somewhere else, since this will be called to make a new CESQL expression as well. The function is doing a bit too much. There should be 2 functions:

Make and add the CESQL function
Parse the CESQL expression into a filter

pkg/eventfilter/subscriptionsapi/cesql_correlationid_filter.go Outdated Show resolved Hide resolved

pkg/eventfilter/subscriptionsapi/cesql_correlationid_filter.go Outdated

+              	if err != nil {
+              		return nil, err
+              	}
+              	secrets, err := clientset.CoreV1().Secrets("default").List(context.Background(), metav1.ListOptions{})

Member

Cali0707 Dec 1, 2024

Probably need to configure:

which namespace to look up secrets in
which secret names to get

knative-prow bot requested a review from pierDipi

December 1, 2024 20:12

d3akhtar added 2 commits

January 27, 2025 14:33


          Moved some code to functions and used kubeclient

3a4c452


          Merge branch 'main' into correlation-id-cesql-user-function

5725c03

knative-prow bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: d3akhtar
Once this PR has been reviewed and has the lgtm label, please assign lionelvillard for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow bot commented Jan 27, 2025

@d3akhtar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
unit-tests_eventing_main	`5725c03`	link	true	`/test unit-tests`
reconciler-tests_eventing_main	`5725c03`	link	true	`/test reconciler-tests`

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Author

d3akhtar commented Jan 28, 2025

@pierDipi How can I use the injected fake kubeclient to create secrets to test my code on? Right now, if I try the tests, I get this error.

panic: Unable to fetch k8s.io/client-go/kubernetes.Interface from context. This context is not the application context (which is typically given to constructors via sharedmain).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test size/L