Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Upgrade to latest dependencies #1649

Merged

Conversation

knative-automation
Copy link
Contributor

Cron -knative-prow-robot

/cc knative/operations-wg-leads
/assign knative/operations-wg-leads

Produced by: knative-extensions/knobots/actions/update-deps

Signed-off-by: Knative Automation <[email protected]>
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch from 33dfc4f to 28b60ea Compare December 5, 2023 13:14
@knative-prow knative-prow bot requested a review from a team December 5, 2023 13:14
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (eef6eaf) 79.40% compared to head (28b60ea) 79.37%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/reconciler/knativeserving/ingress/istio.go 75.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1649      +/-   ##
==========================================
- Coverage   79.40%   79.37%   -0.03%     
==========================================
  Files          41       41              
  Lines        1845     1857      +12     
==========================================
+ Hits         1465     1474       +9     
- Misses        277      279       +2     
- Partials      103      104       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
Copy link

knative-prow bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2023
@knative-prow knative-prow bot merged commit 124c758 into knative:main Dec 6, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants