Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] Update istio gateway from v1alpha3 to v1beta1 (#1628) #1650

Merged

Conversation

houshengbo
Copy link
Contributor

cherry-pick of 5e2d097

@knative-prow knative-prow bot requested review from matzew and maximilien December 6, 2023 11:47
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b675338) 79.23% compared to head (c3749a9) 79.20%.

Files Patch % Lines
pkg/reconciler/knativeserving/ingress/istio.go 75.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.11    #1650      +/-   ##
================================================
- Coverage         79.23%   79.20%   -0.03%     
================================================
  Files                41       41              
  Lines              1830     1842      +12     
================================================
+ Hits               1450     1459       +9     
- Misses              276      278       +2     
- Partials            104      105       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2023
@houshengbo houshengbo force-pushed the cherry-pick-istio-version branch from 6118ae8 to c3749a9 Compare December 6, 2023 12:15
@dprotaso
Copy link
Member

dprotaso commented Dec 6, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
Copy link

knative-prow bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dprotaso,houshengbo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 025464a into knative:release-1.11 Dec 6, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants