Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.17] feat(helm): make PR with changes to deal with branch protection rules #1987

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #1983

NONE

fix: from new branch

fix: syntax

fix: syntax

fix: pr permissions

fix: pr details
@knative-prow knative-prow bot requested review from houshengbo and matzew January 31, 2025 22:37
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 31, 2025
@houshengbo
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
Copy link

knative-prow bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.88%. Comparing base (a049130) to head (a23630a).
Report is 1 commits behind head on release-1.17.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.17    #1987   +/-   ##
=============================================
  Coverage         63.88%   63.88%           
=============================================
  Files                54       54           
  Lines              2622     2622           
=============================================
  Hits               1675     1675           
  Misses              830      830           
  Partials            117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit b602c35 into knative:release-1.17 Jan 31, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants