Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move e2e tests for metrics export to integration status to reduce crosstalk flakiness #1782

Closed
wants to merge 11 commits into from
Closed

Move e2e tests for metrics export to integration status to reduce crosstalk flakiness #1782

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fe41fe3
Move e2e tests for metrics export to integration status to reduce cro…
Oct 7, 2020
21c185f
Fix gofmt
Oct 7, 2020
4470e5c
Add e2e script for pkg.
Oct 12, 2020
73fede0
Mark test executable
Oct 13, 2020
25cf33e
Add common library for e2e tests
Oct 13, 2020
60c3c49
Don't need serving's common library at all
Oct 14, 2020
e7d5ebe
Address Victor's feedback.
Oct 21, 2020
a03b609
Merge remote-tracking branch 'upstream/master' into metrics-e2e
Oct 21, 2020
b2f9091
Merge remote-tracking branch 'upstream/master' into metrics-e2e
Oct 21, 2020
211b2be
Clean up the factory/exporter registration lifecycle. It's fine to Un…
Oct 23, 2020
c7d694f
Clean up isNewExporterRequired
Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions metrics/exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,10 @@ func isNewExporterRequired(newConfig *metricsConfig) bool {
return newConfig.collectorAddress != cc.collectorAddress || newConfig.requireSecure != cc.requireSecure
}

if newConfig.backendDestination == prometheus {
return newConfig.prometheusPort != cc.prometheusPort
}

return newConfig.backendDestination == stackdriver && newConfig.stackdriverClientConfig != cc.stackdriverClientConfig
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return dest=promo && nc.pp != cc.pp || des == stack && nc.sCC != cc.sCC?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might make this a switch, I worry about having a conditional with 4 boolean expressions being hard to maintain.


Expand Down
Loading