Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and fix metrics export tests. #1957

Merged
merged 7 commits into from
Dec 18, 2020
Merged

Refactor and fix metrics export tests. #1957

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
14a8dae
Copy resource_view_test to e2e_test
evankanderson Dec 11, 2020
2f6ecdb
Restore metrics/resource_view_test.go
evankanderson Dec 11, 2020
3e094f8
Refactor metrics tests, fix e2e_test
evankanderson Dec 11, 2020
d12a943
Address yanweiguo feedback
evankanderson Dec 11, 2020
781822d
Cleanup per vagababov
evankanderson Dec 14, 2020
df61543
Merge remote-tracking branch 'upstream/master' into opencensus-fix
Dec 15, 2020
5725836
Switch to zap.Error but avoid the bug the code previously had.
Dec 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metrics/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ func createMetricsConfig(ctx context.Context, ops ExporterOptions) (*metricsConf
}

switch lb := metricsBackend(strings.ToLower(backend)); lb {
case stackdriver, prometheus, openCensus:
case stackdriver, prometheus, openCensus, none:
mc.backendDestination = lb
default:
return nil, fmt.Errorf("unsupported metrics backend value %q", backend)
Expand Down
Loading