Skip to content

Commit

Permalink
accepted to CRAN
Browse files Browse the repository at this point in the history
  • Loading branch information
knausb committed Apr 17, 2018
1 parent a7e04bb commit 47df2e6
Show file tree
Hide file tree
Showing 3 changed files with 321 additions and 2 deletions.
4 changes: 2 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ This may have been addressed at 64a308ba50b9119108e8946737460de5997b805b by addi


# vcfR 1.8.0
Released on CRAN 2018-04-XX
Released on CRAN 2018-04-17
* Attempted to address CRAN's 'Note: break used in wrong context: no loop is visible' issue.
* `.vcf_stats_gz()` reports number of elements in header as well as the files last line. This is used by `read.vcfR()` to check for poorly formed files.
* `.vcf_stats_gz()` reports number of elements in header as well as the file's last line. This is used by `read.vcfR()` to check for poorly formed files.
* `show` method for vcfR now queries @fix instead of @gt.
* `check_keys()` checks key definitions in the meta section to make sure they are unique.
* `freq_peak_plot()` has parameter `posUnits` to adjust units of scatterplot.
Expand Down
25 changes: 25 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,29 @@

## Resubmission
This is a resubmission.
CRAN reported the following after submission.

Found the following (possibly) invalid URLs:
URL: https://software.broadinstitute.org/gatk/
From: inst/doc/converting_data.html
Status: 500
Message: Internal Server Error

Also fails manually for me. A temporary issue?

This link does work from my computer.
I have also asked several lab mates to check it and they have all validated that it works.
I have also rerun tests on winbuilder R version 3.4.4.
https://win-builder.r-project.org/N5kC8mk7aG29/
and winbuilder R version 3.5.0 RC (2018-04-16 r74611)
https://win-builder.r-project.org/Jh34i9ic2m07/
and have failed to reproduce the behaviour.
I think this indicates that the reported behaviour was temporary.

Incidentally, this is an updated link in this release (1.8.0) versus the previous (1.7.0).
The reason for this update is that R CMD check --as-cran told me I had an old link and it even gave me the updated link that is in this current version.
So I think its doing its job.

## Test environments
* local: ubuntu 16.04 LTS, R 3.4.4
* local: OS X install, R 3.4.4
Expand Down
Loading

0 comments on commit 47df2e6

Please sign in to comment.