Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PostgreSQL schema functions #80

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Add PostgreSQL schema functions #80

wants to merge 1 commit into from

Conversation

jamarzka
Copy link

No description provided.

@elhigu
Copy link
Member

elhigu commented Jan 31, 2018

Hi, thanks for PR. Are these functions already implemented? Is there any related issues?

@jamarzka
Copy link
Author

jamarzka commented Feb 1, 2018 •
edited
Loading

Yes these functions are already implemented for PostgreSQL:
https://github.com/tgriesser/knex/blob/master/src/dialects/postgres/schema/compiler.js#L67

No related issues that I'm aware of. This is the original PR when the schema support was added:
knex/knex#518

@elhigu
Copy link
Member

elhigu commented Feb 1, 2018

@jamarzka Thanks for the reference to PR.

I just looked into it and didn't see any tests for createSchemaIfNotExists, dropSchemaIfExists, createSchema, dropSchema so I'd rather not make them official features until there are some tests made written for them. These are so simple queries, that I'm fine with plain unit tests.

@kibertoad kibertoad mentioned this pull request Oct 19, 2018
Open
@github-actions github-actions bot force-pushed the gh-pages branch 3 times, most recently from f604dc1 to 117f1e0 Compare May 28, 2022 13:22
@github-actions github-actions bot force-pushed the gh-pages branch 3 times, most recently from f6eeb15 to f1543d2 Compare June 8, 2022 09:27
@github-actions github-actions bot force-pushed the gh-pages branch 2 times, most recently from f33c7a1 to 8d87b10 Compare June 19, 2022 16:03
@github-actions github-actions bot force-pushed the gh-pages branch 11 times, most recently from a427ab2 to 0786b26 Compare March 29, 2023 20:41
@github-actions github-actions bot force-pushed the gh-pages branch 6 times, most recently from 59b5da9 to a76aea1 Compare July 11, 2023 07:13
@github-actions github-actions bot force-pushed the gh-pages branch 9 times, most recently from 94167c1 to b1bc94d Compare July 18, 2023 07:22
@rluvaton
Copy link
Member

rluvaton commented Mar 2, 2024

The website repo has been moved inside the https://github.com/knex/knex repo. Please open a PR there instead: (the website will be under the docs folder)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamarzka @elhigu @rluvaton