Add VUEs tsv and converting to json script #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leexgh
changed the title
Replace Out_Of_Frame to Frame_Shift Add tsv VUE table Add tsv to json script
inodb
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Looks great!
Some thoughts:
- Good to make it more clear that
VUEs.jsonis generated. Could e.g. do aMakefileto and put theVUEs.jsonin some foldergenerated? - For
VUEs_table.txt, maybe justVUEs.tsv? It is more succinct and clear that it is tab-separated. More of a personal preference thing tho
|
@inodb Good point! Moved to generated folder and add some documents on how to generate the json file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request: