Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in keycloak configuration example #411

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

adamwojs
Copy link
Contributor

Fixed minor typo in keycloak configuration example

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @adamwojs ,

Thank you for this valid misprint fix! But as you can see a built failed because of this. Could you fix it too? It seems you only need to run that bin/update_readme file to recompile the README and commit changes.

Then I would be happy to merge it :)

@adamwojs
Copy link
Contributor Author

Sure, I will update PR later today 😉

@bocharsky-bw
Copy link
Member

OK great! Or let me know if you can't and I'll do it myself :)

@adamwojs
Copy link
Contributor Author

Fixed. The actual typo was in src/DependencyInjection/Providers/KeycloakProviderConfigurator.php 😉

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@bocharsky-bw bocharsky-bw merged commit c26a792 into knpuniversity:master Aug 14, 2023
10 checks passed
@adamwojs adamwojs deleted the adamwojs-patch-1 branch August 14, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants