Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker support #33

Merged
merged 4 commits into from
Feb 11, 2024
Merged

Docker support #33

merged 4 commits into from
Feb 11, 2024

Conversation

anatawa12
Copy link
Collaborator

@anatawa12 anatawa12 commented Aug 23, 2022 •
edited
Loading

Closes #18
Depends on #32 (included in this PR) and #29

anatawa12
anatawa12 commented Aug 23, 2022
View reviewed changes
@anatawa12 anatawa12 marked this pull request as ready for review October 3, 2022 06:55
Sayamame-beans
Sayamame-beans approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockerに詳しくないため詳細な判断は困難ですが、一見問題ないように見えます。
問題なく動作するのであれば、良いと思います。

@Sayamame-beans Sayamame-beans merged commit 6f4973b into master Feb 11, 2024
1 check passed
@Sayamame-beans Sayamame-beans deleted the docker branch February 11, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sayamame-beans Sayamame-beans Sayamame-beans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dockerコンテナの提供
2 participants
@anatawa12 @Sayamame-beans