Skip to content

Commit

Permalink
wip comment
Browse files Browse the repository at this point in the history
  • Loading branch information
p2edwards committed Nov 23, 2024
1 parent e4c409d commit f212d1f
Showing 1 changed file with 20 additions and 4 deletions.
24 changes: 20 additions & 4 deletions .github/filters.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
# Used by workflows to determine whether to continue
# > "If a new PR is opened,
# > and it only changes 1 file, which test(s) should be re-run?"
# Used by workflows

should-run-npm-test:
- '{jsapp,test,webpack,static,scripts}/**/*.!(md|py|sh|bash)' # frontend
Expand All @@ -9,19 +7,24 @@ should-run-npm-test:
- '{.editorconfig,.prettier*,.stylelint*,.eslint*,coffeelint*}' # linters
- '{.gitignore}' # (can affect tools)

# WIP
# WIP - re-enable when done tweaking workflow logic.
# In the future we should re-run test whenever the ci logic is modified.
# but during this PR draft, I want to test if the logic would result
# in a skip if the rule was already established
# - '.github/workflows/npm-test.yml' # ci

should-run-pytest:
- '{kpi,kobo,hub}/**/*.!(md)' # backend
- 'dependencies/**/*.!(md)' # pip
- 'pyproject.toml' # (can affect build/tests)

# WIP
# - '.github/workflows/pytest.yml' # ci

should-run-darker:
- '{kpi,kobo,hub}/**/*.py' # .py
- 'pyproject.toml' # rules

# WIP
# - '.github/workflows/darker.yml' # ci

Expand All @@ -35,3 +38,16 @@ new-files-at-root-level:
# in the other lists.
# (alphabetical order, folders-first)
- '!(((\.github|\.storybook|\.tx|cypress|dependencies|docker|hub|jsapp|kobo|kpi|patches|scripts|static|test|webpack)/**)|(\.babelrc\.json|\.browserslistrc|\.coveragerc|\.dockerignore|\.editorconfig|\.eslintignore|\.eslintrc\.js|\.git-blame-ignore-revs|\.gitattributes|\.gitignore|\.gitlab-ci\.yml|\.gitmodules|\.node-version|\.nvmrc|\.prettierrc\.js|\.stylelintrc\.js|\.swcrc|CONTRIBUTING\.md|Dockerfile|LICENSE|README\.md|coffeelint\.json|dependabot\.yml|format-python\.sh|kpi\.code-workspace|locale|manage\.py|package-lock\.json|package\.json|pip-compile\.sh|pyproject\.toml|tsconfig\.json))'


# Notes:

# Filter syntax is picomatch v4 with {dot:true}. A few quirks:
# - '*' and '**' always act as glob matchers, even in groups
# - in groups (parens), you need to escape '.' with (\.)


# Clarifying question for making these:
#
# > "If a new PR is opened,
# > and it only changes 1 file, which test(s) should be re-run?"

0 comments on commit f212d1f

Please sign in to comment.