Add Python linter to GitHub Actions #5083
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| name: Python linter (Darker) | ||
|
|
||
| on: [pull_request] | ||
| jobs: | ||
| darker: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| - uses: actions/setup-python@v5 | ||
| - name: Install pip dependencies | ||
| run: python -m pip install flake8 flake8-quotes isort | ||
| - uses: akaihola/darker@master | ||
| with: | ||
| options: '--check --isort -L "flake8 --max-line-length=88"' | ||
| revision: "origin/${{ github.event.pull_request.base.ref }}" | ||
| version: "~=2.1.1" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| #!/bin/bash | ||
|
|
||
| BASE_REVISION=$1 | ||
|
|
||
| if [ -n "${UWSGI_USER}" ] && [ "${DEBIAN_FRONTEND}" == "noninteractive" ] && [ "${TMP_DIR}" == "/srv/tmp" ]; then | ||
| INSIDE_CONTAINER=1 | ||
| else | ||
| INSIDE_CONTAINER=0 | ||
| fi | ||
|
|
||
| if [ -z "$BASE_REVISION" ]; then | ||
| BASE_REVISION="origin/beta" | ||
| elif [ "$BASE_REVISION" == "-l" ] || [ "$BASE_REVISION" == "--last" ]; then | ||
| if [ "$INSIDE_CONTAINER" == "1" ]; then | ||
| BASE_REVISION=$(gosu "$UWSGI_USER" git log --oneline| head -n 1 | awk '{ print $1}') | ||
| else | ||
| BASE_REVISION=$(git log --oneline| head -n 1 | awk '{ print $1}') | ||
| fi | ||
| fi | ||
|
|
||
| # First, do not touch formatting but fix: | ||
| # - single/double quotes (--select Q) | ||
| # - sort imports (--select I) | ||
| # - unused imports (--select F401) | ||
| # - deprecated `mock` (--select UP026) | ||
| # - extraneous-parentheses (--select UP034) | ||
| # - Unnecessary parentheses after class definition (--select UP039) | ||
| # - Indentation warning (--select W1) | ||
| # - No newline at end of file (--select W292) | ||
| if [ "$INSIDE_CONTAINER" == "1" ]; then | ||
| PYTHON_CHANGES=$(gosu "$UWSGI_USER" git diff --name-only "$BASE_REVISION" | grep '\.py') | ||
| else | ||
| PYTHON_CHANGES=$(git diff --name-only "$BASE_REVISION" | grep '\.py') | ||
| fi | ||
|
|
||
| if [ -n "$PYTHON_CHANGES" ]; then | ||
| echo "Using ruff..." | ||
| if [ "$INSIDE_CONTAINER" == "1" ]; then | ||
| gosu "$UWSGI_USER" git diff --name-only "$BASE_REVISION" | grep '\.py' | xargs ruff check --select Q --select I --select F401 --select UP026 --select UP034 --select UP039 --select W292 --fix | ||
| else | ||
| git diff --name-only "$BASE_REVISION" | grep '\.py' | xargs ruff check --select Q --select I --select F401 --select UP026 --select UP034 --select UP039 --select W292 --fix | ||
| fi | ||
|
|
||
| # Applying Black format with `darker` with options: | ||
| # --isort: Using isort | ||
| # --revision: Compare changes with revision $BASE_REVISION | ||
| echo "Using darker..." | ||
| if [ "$INSIDE_CONTAINER" == "1" ]; then | ||
| gosu "$UWSGI_USER" darker --isort --revision "$BASE_REVISION" | ||
| else | ||
| darker --isort --revision "$BASE_REVISION" | ||
| fi | ||
| else | ||
| echo "No Python changes detected!" | ||
| fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidental change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, produced by
./pip-compile.shThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird. It seems unrelated to the changes, which is a little worrisome.