feat(organizations): add functions for managing members TASK-985 #5281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-endpoints-to-handle-org-members
… query for user mfa details
…hook more customizable and then use it in `MembersRoute`
…hook more customizable and then use it in `MembersRoute`
…x/kpi into leszek/task-980-members-table
…eszek/task-980-members-table
…omprehensive tests
…omprehensive tests
…eszek/task-980-members-table
…x/kpi into leszek/task-980-members-table
…eszek/task-980-members-table
…x/kpi into leszek/task-980-members-table
…ber-mutation-api # Conflicts: # jsapp/js/account/organization/membersQuery.ts
magicznyleszek
requested review from
p2edwards
and removed request for
p2edwards
# Conflicts: # jsapp/js/account/organization/MembersRoute.tsx # jsapp/js/account/organization/membersQuery.ts # jsapp/js/api.endpoints.ts # kobo/apps/organizations/serializers.py # kobo/apps/organizations/views.py
Akuukis
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
LGTM, not tested. I like how simple getMemberEndpoint approach is, for now let's stick to that.
Once we get to API schema auto-generation and auto-generated types, preferrably with auto-generated helpers, then let's worry later about what concerns and restrictions that will bring.
pauloamorimbr
approved these changes
Dec 5, 2024
pauloamorimbr
approved these changes
Dec 5, 2024
| * Mutation hook for updating organization member. It ensures that all related | ||
| * queries refetch data (are invalidated). | ||
| */ | ||
| export function usePatchOrganizationMember(username: string) { |
There was a problem hiding this comment.
In the hypothetical situation where we could need to call multiple usePatch... in the same view we might want to have the username as a parameter of the mutationFn itself instead of the hook.
But that's only to stay in our minds for the future. We can change this is needed.
magicznyleszek
added a commit
that referenced
this pull request
Dec 11, 2024
… members TASK-987 TASK-990 (#5309) ### 📣 Summary In Members Table (from Account → Team/Organization → Members) add actions dropdown with one action. The action allows removing a member or leaving the organization. ### 📖 Description The availability of "Remove" action is based on the role of the logged in user. When trying to remove user (or leave organization) a confirmation prompt is being shown. ### 👀 Preview steps 1. ℹ️ have multiple different users 2. for one of the users (e.g. "joe"), use http://kf.kobo.local/admin/organizations/organization/ to add multiple users into joe's organization 3. For one of the users (e.g. "sue") set the role to "admin" 4. enable "Multi-members override" for joe's organization 5. enable feature flag `mmosEnabled` 6. navigate to `#/account/organization/members` 7. 🟢 notice that a table of organization members displays a list of users added in step 2 8. 🟢 notice that in the table "joe" (as owner) has an ability to remove all organization members (excluding themselves) including "sue" who's an admin As continuation for above steps: 1. log in as "sue" 2. navigate to `#/account/organization/members` 3. 🟢 notice that in the table "joe" (the owner) has no actions available 4. 🟢 notice that any "member" user in the table has actions available, and if you click "Remove" a confirmation prompt will appear 5. 🟢 notice that for "sue" the action available is "Leave team"/"Leave organization", and if you click it, a confirmation prompt will appear - and it will have different content than confirmation prompt for removing a member As continuation for above steps: 1. pick a "member" user and use "Remove" action 2. confirm prompt 3. 🟢 verify that user was removed successfuly ### 💭 Notes Build atop #5281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💭 Notes
Not testable per se until further PR is built atop this one and uses it :)