ci: skip tests if unaffected TASK-1316 #5295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
p2edwards
force-pushed
the
phil/ci-paths-filter
branch
from
de99c3f to
d3b9d92
Compare
p2edwards
changed the title
p2edwards
changed the title
p2edwards
force-pushed
the
phil/ci-paths-filter
branch
from
6f64040 to
d84067d
Compare
p2edwards
force-pushed
the
phil/ci-paths-filter
branch
from
d84067d to
7580008
Compare
Looks like the checks at the bottom of the PR follows the order defined in ci.yml. Place npm-test after the python jobs since the npm-test is a 4-entry matrix right now and buries the others below the scroll fold Place pytest on top. it's usually there while you're waiting since it takes the longest, so this time it doesn't have to move. Make both files use the same order. Give "detect changed files" a name to make it easier to find when you're inspecting results
this code solves a rare problem and could go in a separate PR after discussion the "unknown files" detection would support this scenario: - a new config file or folder gets merged in without being included in filters.yml. - time passes. - a small pr modifies that config, breaking the ci job, which is skipped because filters.yml is out of date.
p2edwards
changed the title
p2edwards
requested review from
bufke,
jnm,
noliveleger and
magicznyleszek
as code owners
Akuukis
force-pushed
the
phil/ci-paths-filter
branch
from
33ad903 to
df60d52
Compare
Akuukis
approved these changes
Dec 2, 2024
p2edwards
commented
Dec 2, 2024
Comment on lines
+6
to
+15
| darker: | ||
| - '{kpi,kobo,hub}/**/*.py' # .py | ||
| - 'pyproject.toml' # rules | ||
| - '.github/workflows/darker.yml' # ci | ||
|
|
||
| pytest: | ||
| - '{kpi,kobo,hub}/**/*.!(md)' # backend | ||
| - 'dependencies/**/*.!(md)' # pip | ||
| - 'pyproject.toml' # (can affect build/tests) | ||
| - '.github/workflows/pytest.yml' # ci |
There was a problem hiding this comment.
backend-related paths that will trigger darker/pytest
cc @noliveleger
p2edwards
commented
Dec 2, 2024
Comment on lines
+17
to
+23
| npm-test: | ||
| - '{jsapp,test,webpack,static,scripts}/**/*.!(md|py|sh|bash)' # frontend | ||
| - '{package*.json,patches/*.patch,scripts/copy_fonts.py}' # npm + postinstall | ||
| - '{tsconfig.json,.swcrc,.babelrc*,.browserslistrc}' # compilers | ||
| - '{.editorconfig,.prettier*,.stylelint*,.eslint*,coffeelint*}' # linters | ||
| - '.gitignore' # (can affect tools) | ||
| - '.github/workflows/npm-test.yml' # ci |
There was a problem hiding this comment.
frontend-related paths that will trigger npm-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 Preview steps
💭 Notes
darker.yml,npm-test.yml, andpytest.ymlworkflow files, so all the jobs are run:)