New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(organizations): add queryclientprovider to basic layout TASK-1324 #5322

Merged

jamesrkiger merged 1 commit into main from task-1324-fix-queryclientprovider-error

Dec 3, 2024

Contributor

jamesrkiger commented Dec 3, 2024 •

edited

Loading

🗒️ Checklist

run linter locally
update all related docs (API, README, inline, etc.), if any
draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
tag PR: at least frontend or backend unless it's global
fill in the template below and delete template comments
review thyself: read the diff and repro the preview as written
open PR & confirm that CI passes
request reviewers, if needed
delete this section before merging

📣 Summary

Add QueryClientProvider to BasicLayout so react-query is accessible for TOS and invalidated password views.

👀 Preview steps

Set up an MMO member account that has not accepted required TOS agreement
Login.
On main, an error will be thrown by react-query
On this branch, no error will be thrown.


          Add queryClientProvider to BasicLayout component

71881bd

jamesrkiger requested a review from magicznyleszek as a code owner

December 3, 2024 19:28

jamesrkiger requested a review from pauloamorimbr

December 3, 2024 19:31

pauloamorimbr approved these changes

View reviewed changes

Contributor

pauloamorimbr left a comment

LGTM! 💯

jamesrkiger merged commit be25956 into main

7 checks passed

jamesrkiger deleted the task-1324-fix-queryclientprovider-error branch

December 3, 2024 21:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet