-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(organizations): add theming/story for Mantine Select TASK-1379 #5414
feat(organizations): add theming/story for Mantine Select TASK-1379 #5414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌 not tested
Weird issue here: To reproduce:
Obviously this is an edge case and I'm not sure if it's really a bug or if it's more a question of how our hover and focus style choices are interacting. Let me know what you think. |
Can we make it so the select closes when a user tabs to the next element? On the members table, if I open the select then tab to the member actions button, the select stays open and now I can't close it with 'esc'. I am noticing that this is also how the select behaves in Mantine examples, unfortunately, but I do think it's wrong and would be worth fixing if possible. |
dc40a00
to
65f23c5
Compare
I tried hard but I just wasn't able to fix this behavior. I came to a point where it would be better to just get Mantine's select code and change it's implementation to add our needed behaviors and have a better control to fix this. 😞 We may end up doing just that in a future task. |
Just to mention that in geenral some styles were changed (this one you found was really a bug tho) so we aren't really following the current koboSelect styling in favor of following Tessa's indications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would appreciate it if could deprecate the old KoboSelect story. Other than that, lgtm
9246a21
to
13bd383
Compare
…Overlay TASK-1464 (#5425) ### 📣 Summary Theming for Mantine's Loader and LoadingOverlay was added to match Kobo's current LoadingSpinner for general purpose. ### 📖 Description Both 'regular' and 'big' variant were added with its respective type names to be used with Mantine's `Loader` and `LoadingOverlay` components. To simplify the implementation I decided to simply use the existing `LoadingSpinner` component instead of extracting it's contents. Since Mantine's `Loader` doesn't have the `message` parameter, right now I'm fixing it on `false` so it won't appear. We may need to implement a Wrapper in the future to add a message, depending on our future needs. * `LoadingOverlay` is already in use at #5414 ### 👀 Preview steps - Use storybook to check the visual of the component and compare with the existing loader in use in the app.
🗒️ Checklist
<type>(<scope>)<!>: <title> TASK-1234
frontend
orbackend
unless it's global📣 Summary
Theming for Mantine's Select was added to match our KoboSelect visual
📖 Description
MantineSelect
as it is, which may cause us to end up adding our own implementation based on Matine's one:clearable
is enabled and an item is selected, the chevron becomes unclickableAlso:
LoadingOverlay
is being used in the members table to keep the user from doing other actions while processing the role change. The functionality seems good, but we need to setup the Loader theme as well for it to be used like that. Preferably in another task.👀 Preview steps