Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mantine): adjust theme color hsl formatting #5427

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix(mantine): adjust theme color hsl formatting #5427

merged 1 commit into from
Jan 20, 2025

Conversation

jamesrkiger
Copy link
Contributor

@jamesrkiger jamesrkiger commented Jan 20, 2025 •
edited
Loading

🗒️ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

📣 Summary

Fixes formatting of our Mantine HSL theme color codes.

📖 Description

Mantine sometimes attempts to parse HSL codes with a regex that does not recognize 'deg' as a unit and expects comma-separated values.

👀 Preview steps

This shouldn't have any impact on existing designs. Can be confirmed in storybook

@jamesrkiger jamesrkiger requested review from pauloamorimbr and Akuukis and removed request for magicznyleszek and Akuukis January 20, 2025 12:55
@jamesrkiger jamesrkiger self-assigned this Jan 20, 2025
pauloamorimbr
pauloamorimbr approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@pauloamorimbr pauloamorimbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🖌️

@jamesrkiger jamesrkiger changed the title fix(mantine): fix theme color hsl formatting fix(mantine): adjust theme color hsl formatting Jan 20, 2025
@jamesrkiger jamesrkiger merged commit de1a583 into main Jan 20, 2025
7 checks passed
@jamesrkiger jamesrkiger deleted the mantine-color-theme-fix branch January 20, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauloamorimbr pauloamorimbr pauloamorimbr approved these changes

Assignees

@jamesrkiger jamesrkiger

Labels
Front end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesrkiger @pauloamorimbr