Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(accesslogs) display logout all button TASK-859 #5429

Merged
merged 1 commit into from
Jan 22, 2025
Merged

feat(accesslogs) display logout all button TASK-859 #5429

merged 1 commit into from
Jan 22, 2025

Conversation

jamesrkiger
Copy link
Contributor

@jamesrkiger jamesrkiger commented Jan 20, 2025 •
edited
Loading

🗒️ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

📣 Summary

Makes previously hidden logout-all button accessible

👀 Preview steps

  1. Log in on two separate browsers
  2. Access security settings page in one browser and press logout all button
  3. See that you are logged out from other browser session

@jamesrkiger jamesrkiger changed the title Put logout all button back in security settings. feat(accesslogs) display logout all button TASK-859 Jan 20, 2025
@jamesrkiger jamesrkiger self-assigned this Jan 20, 2025
@jamesrkiger jamesrkiger requested review from magicznyleszek and pauloamorimbr and removed request for magicznyleszek January 20, 2025 18:03
pauloamorimbr
pauloamorimbr approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@pauloamorimbr pauloamorimbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

Tested and it seems to be working nicely.

@jamesrkiger jamesrkiger merged commit 2043fd1 into release/2.024.36 Jan 22, 2025
6 checks passed
@jamesrkiger jamesrkiger deleted the task-859-uncomment-logout-all branch January 22, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauloamorimbr pauloamorimbr pauloamorimbr approved these changes

Assignees

@jamesrkiger jamesrkiger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesrkiger @pauloamorimbr