Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(OpenRosa): remove some deprecated endpoints of v1 not called anymore by KPI TASK-1356 #5438

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Guitlle
Copy link
Contributor

@Guitlle Guitlle commented Jan 22, 2025

🗒️ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

📣 Summary

The OpenRosa V1 API contains many endpoints that are deprecated because the functionality is no longer needed as a REST API but rather as code utilities and classes, instead. The deleted endpoints are:

  • bulk_delete
  • bulk_validation_status
  • validation_status
  • destroy
  • enketo
  • enketo_edit
  • enketo_view

📖 Description

This PR deletes deprecated code, endpoints and tests, from the OpenRosa V1 API

👀 Preview steps

No preview steps are needed, all unit tests are passing.

@Guitlle Guitlle marked this pull request as ready for review January 22, 2025 17:29
@Guitlle Guitlle removed request for jnm and noliveleger January 23, 2025 16:51
@noliveleger noliveleger self-requested a review January 27, 2025 09:12
@noliveleger noliveleger changed the title chore(OpenRosa): Remove some deprecated endpoints of v1 not called anymore by KPI TASK-1356 chore(OpenRosa): remove some deprecated endpoints of v1 not called anymore by KPI TASK-1356 Jan 27, 2025
Copy link
Contributor

@noliveleger noliveleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need to add a REMOVALS.md like we did in KoboCAT repo.
https://github.com/kobotoolbox/kobocat/blob/main/REMOVALS.md

Please have a look at README in KoboCAT to do something similar in kobo/apps/openrosa/README which would points to a REMOVALS.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants