Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate Immutablex #11444

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

deprecate Immutablex #11444

wants to merge 2 commits into from

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Feb 25, 2025

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs QA check

  • @kodadot/qa-guild please review

Context

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image

Summary by CodeRabbit

  • New Features

    • Adjusted the landing page and dropdown menus so that top collections now display for all supported networks.
  • Refactor

    • Streamlined network support by removing a specific blockchain network across balance calculations, asset configurations, endpoints, and service integrations, ensuring a more consistent and focused user experience.

These updates provide accurate collection displays and uniform functionality across key application areas such as profiles, balances, and transactions.

@Jarsen136 Jarsen136 requested a review from a team as a code owner February 25, 2025 11:31
@Jarsen136 Jarsen136 requested review from preschian and hassnian and removed request for a team February 25, 2025 11:31
Copy link

coderabbitai bot commented Feb 25, 2025

Walkthrough

This pull request removes all references and configurations related to the imx (Immutable/immutableZkEvm) chain. The updates span UI components, composable functions, static configuration files, type definitions, plugins, stores, and utility modules. In each file, entries, mappings, or properties for the imx chain have been removed or updated, ensuring that the chain is no longer processed by the application.

Changes

File(s) Change Summary
components/landing/LandingPage.vue, components/landing/topCollections/TopCollections.vue Removed imx chain exclusion logic: updated constant and removed :exclude property for the ChainDropdown.
components/profile/ProfileDetail.vue Removed imx from the EVM chains in the async data fetch, limiting processing to the base chain.
composables/useMultipleBalance.ts, composables/useRamp.ts, composables/useTransak.ts Removed imx/ImmutableX references from balance mappings, asset definitions, and chain configuration.
libs/static/src/chains.ts, libs/static/src/endpoints.ts, libs/static/src/indexers.ts, libs/static/src/names.ts, libs/static/src/services.ts Deleted imx entries from chain configurations, endpoint maps, indexers, naming records, and explorer URLs.
libs/static/src/types.ts, plugins/wagmi.client.ts Updated type definitions and plugin configuration to exclude imx/immutableZkEvm chain.
stores/identity.ts Removed the 'immutablex' chain type and its associated asset from identity and balance setup.
utils/teleport.ts, utils/viem.ts Eliminated imx/immutableZkEvm references and mappings from enums, utility functions, and chain currency logic.

Poem

I'm a little rabbit, hopping with glee,
Saying farewell to imx, now set free.
Code paths are clearer, with changes so neat,
No more extra chains in the fleet.
Happy hops in our code, as the updates repeat!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a87a950 and 0f79d41.

📒 Files selected for processing (16)
  • components/landing/LandingPage.vue (1 hunks)
  • components/landing/topCollections/TopCollections.vue (0 hunks)
  • components/profile/ProfileDetail.vue (1 hunks)
  • composables/useMultipleBalance.ts (0 hunks)
  • composables/useRamp.ts (0 hunks)
  • composables/useTransak.ts (0 hunks)
  • libs/static/src/chains.ts (0 hunks)
  • libs/static/src/endpoints.ts (0 hunks)
  • libs/static/src/indexers.ts (0 hunks)
  • libs/static/src/names.ts (0 hunks)
  • libs/static/src/services.ts (0 hunks)
  • libs/static/src/types.ts (1 hunks)
  • plugins/wagmi.client.ts (2 hunks)
  • stores/identity.ts (0 hunks)
  • utils/teleport.ts (0 hunks)
  • utils/viem.ts (1 hunks)
💤 Files with no reviewable changes (11)
  • libs/static/src/services.ts
  • composables/useRamp.ts
  • libs/static/src/endpoints.ts
  • libs/static/src/indexers.ts
  • composables/useTransak.ts
  • stores/identity.ts
  • utils/teleport.ts
  • composables/useMultipleBalance.ts
  • components/landing/topCollections/TopCollections.vue
  • libs/static/src/chains.ts
  • libs/static/src/names.ts
⏰ Context from checks skipped due to timeout of 90000ms (18)
  • GitHub Check: Redirect rules
  • GitHub Check: Header rules
  • GitHub Check: Pages changed
  • GitHub Check: Redirect rules
  • GitHub Check: Header rules
  • GitHub Check: Pages changed
  • GitHub Check: shard (10, 10)
  • GitHub Check: shard (9, 10)
  • GitHub Check: shard (8, 10)
  • GitHub Check: shard (7, 10)
  • GitHub Check: shard (6, 10)
  • GitHub Check: shard (5, 10)
  • GitHub Check: shard (4, 10)
  • GitHub Check: shard (3, 10)
  • GitHub Check: shard (2, 10)
  • GitHub Check: build
  • GitHub Check: build-cf
  • GitHub Check: shard (1, 10)
🔇 Additional comments (5)
libs/static/src/types.ts (1)

1-1: Removal of 'imx' from the Prefix type

The 'imx' string literal has been removed from the Prefix type definition, which aligns with the PR objective to deprecate the Immutable X functionality. This change ensures that the type system no longer recognizes 'imx' as a valid chain prefix.

components/profile/ProfileDetail.vue (1)

816-816: Removed 'imx' from EVM chains array

The 'imx' entry has been removed from the EVM chains array, which means the ProfileDetail component will no longer fetch data for the Immutable X chain when determining which empty result tabs to show. This change is consistent with the overall deprecation of Immutable X functionality.

utils/viem.ts (1)

2-2: Removed immutableZkEvm import and mappings

The import for immutableZkEvm has been removed along with its associated entries in both the CHAIN_ID_TO_PREFIX and PREFIX_TO_CHAIN mappings. This ensures that the application no longer maps between Immutable X chain IDs and the 'imx' prefix.

plugins/wagmi.client.ts (1)

3-3: Removed immutableZkEvm from wagmi configuration

The immutableZkEvm chain has been removed from both the import statement and the chains array in the wagmiConfig. This ensures that the application no longer attempts to connect to the Immutable X network when establishing blockchain connections.

Also applies to: 16-16

components/landing/LandingPage.vue (1)

44-44: Removal of 'imx' from forbidden prefixes is consistent with deprecation goal.

This change removes 'imx' from the array of forbidden prefixes for top collections, which aligns with the PR objective of deprecating Immutable X throughout the codebase. The removal is appropriate since the entire Immutable X chain support is being deprecated, making specific exclusion rules for it unnecessary.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for polkadot ready!

Name Link
🔨 Latest commit 83022d4
🔍 Latest deploy log https://app.netlify.com/sites/polkadot/deploys/67bed34a8dc3010008449c70
😎 Deploy Preview https://deploy-preview-11444--polkadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 83022d4
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/67bed34a309d340008b3e662
😎 Deploy Preview https://deploy-preview-11444--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hise Mantle and Imutable from menu
3 participants