feat: redesign update price and transfer item on gallery

[preschian]

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

• Bugfix
• Feature
• Refactoring

Context

• Closes Gallery Item Desktop - integrate list, transfer, and change price #4543

Before submitting pull request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality
• I've posted a screenshot of demonstrated change in this PR

Optional

• I've tested it at </bsx/collection>
• I've tested PR on mobile
• I've written unit tests 🧪
• I've found edge cases

Had issue bounty label?

• Fill up your KSM address: Payout

Community participation

• Are you at KodaDot Discord?

Screenshot 📸

• My fix has changed something on UI; a screenshot is best to understand changes for others.

[netlify]

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	34d5e48
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/63bee8fea5180b00081c2a8d
😎 Deploy Preview	https://deploy-preview-4652--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[roiLeo]

Hey!
I see you're writting some actions logic and I was wondering if it was really a good idea to have a switch case instead of a if statement?
Shouldn't it be moved to a file outside this component?

[preschian]

if it was really a good idea to have a switch case instead of a if statement?

hhmm, I don't see any difference between switch-case or if statement for this case

Shouldn't it be moved to a file outside this component?

will consider it 👍

[vikiival]

Hello, please resolve code climate issues

I find useGalleryItemAction really hard to read

[vikiival]

Last things:

• how would you handle new chain ?

[preschian]

I find useGalleryItemAction really hard to read

need your feedback about this, how about now? is it still not readable?

how would you handle new chain ?

first, I separate based on the key of Interaction
and then, build params based on chain
in case we want to add another chain for Interaction.List, put it inside here https://github.com/kodadot/nft-gallery/blob/feat/redesign-update-price/components/gallery/GalleryItemAction/GalleryItemActionType/useGalleryItemAction.ts#L43-L64
for example:

  if (item.urlPrefix === 'chain-name') {
    executeTransaction({
      cb: api.tx.something.any,
      arg: [chainResolver(any, name)],
      successMessage: item.successMessage,
      errorMessage: item.errorMessage,
    })
  }

[vikiival]

kodadot/packages#89

[vikiival]

Tested list and send

https://deploy-preview-4652--koda-nuxt.netlify.app/rmrk/gallery/16143102-8cc1b91e899d9be40e-2CENTS-BREAKFAST_IN_SUBWORK-0000000000000008

Looks like it works

[vikiival]

Code LGTM.

I would like to invite other pair of eyes for this

[Jarsen136]

except for some new translations words, otherwise lgtm

[vikiival]

@preschian please add translations and we can move it

[codeclimate]

Code Climate has analyzed commit 34d5e48 and detected 0 issues on this pull request.

View more on Code Climate.