#2127 allow resetting window opacity through window rules

CHANGELOG.md

@@ -19,6 +19,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 - Managed windows should snap back into place when moved incorrectly using the mouse [#1199](https://github.com/koekeishiya/yabai/issues/1199) [#2066](https://github.com/koekeishiya/yabai/issues/2066)
 - Managed windows should correct their frame when modified by external means [#2117](https://github.com/koekeishiya/yabai/issues/2117)
 - Window frame would sometimes not be set correctly when using window animations [#2120](https://github.com/koekeishiya/yabai/issues/2120)
+- Allow resetting window opacity in window rules [#2127](https://github.com/koekeishiya/yabai/issues/2127)
 
 ## [6.0.15] - 2024-02-22
 ### Changed

doc/yabai.1

@@ -775,11 +775,15 @@ When focusing the window, put the mouse at its center. Overrides the global \fBm
 \fBlayer=\fI<LAYER>\fP\fP
 .RS 4
 Window is ordered within the given stacking layer. The window will no longer be eligible for automatic change in layer when managed/unmanaged.
+.br
+Specify the value \fIauto\fP to reset back to normal and make it become automatically managed.
 .RE
 .sp
 \fBopacity=\fI<FLOAT_SEL>\fP\fP
 .RS 4
 Set window opacity. The window will no longer be eligible for automatic change in opacity upon focus change.
+.br
+Specify the value \fI0.0\fP to reset back to full opacity and make it become automatically managed.
 .RE
 .sp
 \fBnative\-fullscreen=\fI<BOOL_SEL>\fP\fP

doc/yabai.asciidoc

@@ -558,10 +558,12 @@ ARGUMENT
     When focusing the window, put the mouse at its center. Overrides the global *mouse_follows_focus* setting.
 
 *layer='<LAYER>'*::
-    Window is ordered within the given stacking layer. The window will no longer be eligible for automatic change in layer when managed/unmanaged.
+    Window is ordered within the given stacking layer. The window will no longer be eligible for automatic change in layer when managed/unmanaged. +
+    Specify the value 'auto' to reset back to normal and make it become automatically managed.
 
 *opacity='<FLOAT_SEL>'*::
-    Set window opacity. The window will no longer be eligible for automatic change in opacity upon focus change.
+    Set window opacity. The window will no longer be eligible for automatic change in opacity upon focus change. +
+    Specify the value '0.0' to reset back to full opacity and make it become automatically managed.
 
 *native-fullscreen='<BOOL_SEL>'*::
     Window should enter native macOS fullscreen mode.

src/message.c

@@ -2316,7 +2316,7 @@ static void handle_domain_rule(FILE *rsp, struct token domain, char *message)
             } else if (string_equals(key, ARGUMENT_RULE_KEY_ALPHA)) {
                 if (exclusion) unsupported_exclusion = key;
 
-                if ((sscanf(value, "%f", &rule.alpha) != 1) || (!in_range_ei(rule.alpha, 0.0f, 1.0f))) {
+                if ((sscanf(value, "%f", &rule.alpha) != 1) || (!in_range_ii(rule.alpha, 0.0f, 1.0f))) {
                     daemon_fail(rsp, "invalid value '%s' for key '%s'\n", value, key);
                     did_parse = false;
                 }

src/window_manager.c

@@ -180,7 +180,7 @@ void window_manager_apply_rule_to_window(struct space_manager *sm, struct window
         window_manager_set_window_layer(window, rule->layer);
     }
 
-    if (in_range_ei(rule->alpha, 0.0f, 1.0f)) {
+    if (in_range_ii(rule->alpha, 0.0f, 1.0f)) {
         window->opacity = rule->alpha;
         window_manager_set_opacity(wm, window, rule->alpha);
     }