Test update

koenderks · Dec 19, 2024 · 49136be · 49136be
1 parent 58ede5e
commit 49136be
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tests/testthat/test-fairness-selection.R b/tests/testthat/test-fairness-selection.R
@@ -22,7 +22,7 @@ test_that(desc = "Validation of fairness selection", {
   expect_equal(outcome$measure, "pp")
   # Equalized odds
   outcome <- fairness_selection(q1 = 1, q2 = 3)
-  expect_equal(outcome$measure, "dp")
+  expect_equal(outcome$measure, "eo")
   # False negative rate parity
   outcome <- fairness_selection(q1 = 1, q2 = 2, q3 = NULL, q4 = 2)
   expect_equal(outcome$measure, "fnrp")

diff --git a/tests/testthat/test-model-fairness.R b/tests/testthat/test-model-fairness.R
@@ -53,7 +53,7 @@ test_that(desc = "Benchmark against fairness package", {
   fairness_tpr <- fairness::equal_odds(compas, outcome = "TwoYrRecidivism", preds = "Predicted", group = "Ethnicity", outcome_base = "no", base = "Caucasian")$Metric
   expect_equal(jfa_tprp[["metric"]][["all"]][["estimate"]], as.numeric(fairness_tpr[1, ]))
   expect_equal(jfa_tprp[["parity"]][["all"]][["estimate"]], as.numeric(fairness_tpr[2, ]))
-  # Negative predicted value parity
+  # Negative predictive value parity
   jfa_npvp <- model_fairness(compas, "Ethnicity", "TwoYrRecidivism", "Predicted", privileged = "Caucasian", positive = "yes", metric = "npvp")
   fairness_npv <- fairness::npv_parity(compas, outcome = "TwoYrRecidivism", preds = "Predicted", group = "Ethnicity", outcome_base = "no", base = "Caucasian")$Metric
   expect_equal(jfa_npvp[["metric"]][["all"]][["estimate"]], as.numeric(fairness_npv[1, ]))