Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of the abbreviations #206

Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open

Update of the abbreviations #206

wants to merge 5 commits into from

Conversation

federicapicogna
Copy link
Contributor

No description provided.

koenderks
koenderks requested changes Dec 16, 2024
View reviewed changes
Copy link
Owner

@koenderks koenderks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Didn't we settle on negative predictive rate parity? Why the change back to negative predictive value? I think you might not have reset your development branch after merging your previous pull request.
  2. What happens when you use metric = "eo" in model_fairness(). It should at least give a warning message or something that it is not possible.
  3. Can you make sure that the unit tests work again.
  4. Change "dp" back to "pp" since the proportional parity is equivalent to the disparate impact. "dp" is demographic parity and is calculated as (TP + FP)

@federicapicogna
Update abbreviations
bb774e5
@federicapicogna
Update
520d38e 
Predicted changed into predictive,
confusion matrix inverted,
disparate impact is pp and not dp,
missing = error for eo
@koenderks
Copy link
Owner

Unit tests still fail:

Failure ('test-fairness-selection.R:25:3'): Validation of fairness selection ──
outcome$measure not equal to "dp".
1/1 mismatches
x[1]: "eo"
y[1]: "dp"

@koenderks koenderks self-requested a review December 17, 2024 14:34
koenderks
koenderks requested changes Dec 18, 2024
View reviewed changes
Copy link
Owner

@koenderks koenderks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the unit tests

@koenderks
Copy link
Owner

I think this still needs the error handing for metric="eo", right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koenderks koenderks Awaiting requested review from koenderks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@federicapicogna @koenderks