[Week6] 전현수: 거리두기 확인, 동전 0, 수리공 항승, 큰 수 만들기, 신입 사원, 잃어버린 괄호 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soopeach
changed the title
Comment on lines
+47
to
+48
| val dx = intArrayOf(-1,1,0,0) | ||
| val dy = intArrayOf(0,0,-1,1) |
There was a problem hiding this comment.
dxdy를 List<Pair<Int, Int>> 로 사용하면 좀더 가독성이 효율적일거 같아요
| } | ||
|
|
||
| // 내림차순 정렬 | ||
| coinList.sortedByDescending { it }.forEach { |
There was a problem hiding this comment.
문제에 이미 소팅이 되어있는 거라 reverse만 해주셔도 됩니다
Comment on lines
+22
to
+28
| if (index == 0) { | ||
| // 마지막으로 테이프를 붙인 위치는 테이프를 붙인 위치 - 0.5를 해줌. | ||
| lastLocation = location - 0.5f | ||
| // 필요한 테이프 1 증가. | ||
| needTape++ | ||
| return@forEachIndexed | ||
| } |
There was a problem hiding this comment.
index 그냥 0은 반복문 전에 사용했으면 내부에 retrun을 주지 않아도 되서 괜찮았을거 같아요
| } | ||
|
|
||
| // 지원자의 서류심사 순위로 오름차순 정렬 | ||
| gradeList.sortBy{it.first} |
There was a problem hiding this comment.
sort도 괜찮은데 priorityQueue도 활용해보면 좋을거같아요
Comment on lines
+40
to
+43
| if (indexForOperator <= minusLoation || minusLoation == -1){ | ||
| num += dividedNum | ||
| } else { | ||
| num -= dividedNum |
There was a problem hiding this comment.
마지막에 합을 한걸로 뺴고 더하는데 반복문 내에 있으니까 sumOf 같은 연산으로 간단하게 작성이 가능했을거같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Issue Number
linked issue #26
💎 문제 해결
🔥 특이사항/질문
자유롭게 작성해주세요!
신입 사원, 잃어버린 괄호 문제는 구현이 어려운 문제는 아니었는데, 문제를 이상하게 이해해서 시간 낭비를 엄청했네요..
큰 수 만들기는 조합으로 푸는 로직밖에 생각을 못해서 구글링을 통하여 해결하였습니다.