chore(s3): encode url for returning public url #602
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shigma
reviewed
Apr 10, 2022
| @@ -41,7 +41,7 @@ class S3Assets extends Assets { | |||
| } | |||
| const { buffer, filename } = await this.analyze(url, file) | |||
| const s3Key = `${this.config.pathPrefix}${filename}` | |||
| const finalUrl = `${this.config.publicUrl}${filename}` | |||
| const finalUrl = `${this.config.publicUrl}${encodeURIComponent(filename)}` | |||
There was a problem hiding this comment.
Is slash expected as a suffix for publicUrl?
There was a problem hiding this comment.
This is designed to match the same behavior as pathPrefix.
MaikoTan
approved these changes
Apr 11, 2022
shigma
force-pushed
the
master
branch
3 times, most recently
from
a13f0aa
to
8cb4069
Compare
shigma
force-pushed
the
master
branch
13 times, most recently
from
a6380b3
to
d2d815c
Compare
shigma
force-pushed
the
master
branch
2 times, most recently
from
e08f6e0
to
78d105d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 provides public assets with encoded filename. it should be encoded here.