-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get cmake --build --target install
working
#14
Conversation
* Add a CI check for installation * Add KokosComm_INSTALL_TESTING option to test an install * Flatten include structure * Remove some unused testing code in CMake * Add KokkosComm::KokkosComm target alias
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a great idea, but it can be implemented in a simpler manner I think.
You can make the tests an independent project that contains a
if (NOT TARGET KokkosComm::KokkosComm)
find_package(KokkosComm REQUIRED)
endif()
This way, we do not need special option and we keep the main CMakeLists.txt clean.
… _ROOT CMake variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little skeptical about using mpicxx
as a compiler.
MPI
does not require it and it can make things strange mixing with gpu
compilers.
However, this change can be done in a separate PR if you prefer to ensure all part of the repository are updated.
I agree, let's tackle this in another PR. I created an issue: https://github.com/cwpearson/kokkos-comm/issues/17 |
original below
-DKokkosComm_INSTALL_TESTING=ON
that usesfind_package
to find KokkosComm and then builds unit tests and perf tests against that