Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traces to areas where we suspect launcher could be slow and/or hanging #2059

Merged

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Jan 22, 2025

  • osquery instance restart (includes osquery instance shutdown and thus errgroup shutdown)
  • FlagsChanged
  • control service Fetch

Notable traces:

  • code.function: github.com/kolide/launcher/ee/agent/flags.(*FlagController).notifyObservers
  • code.function: github.com/kolide/launcher/ee/control.(*ControlService).Fetch
  • code.function: github.com/kolide/launcher/ee/tuf.(*TufAutoupdater).checkForUpdate
  • code.function: github.com/kolide/launcher/pkg/osquery/runtime.(*Runner).Restart
  • code.function: github.com/kolide/launcher/ee/errgroup.(*LoggedErrgroup).Wait
  • code.function: github.com/kolide/launcher/ee/desktop/user/client.(*client).Refresh, code.function: github.com/kolide/launcher/ee/desktop/user/client.(*client).Shutdown, code.function: github.com/kolide/launcher/ee/desktop/user/client.(*client).Ping, code.function: github.com/kolide/launcher/ee/desktop/user/client.(*client).ShowDesktop
  • code.function: github.com/kolide/launcher/ee/consoleuser.CurrentUids, code.function: github.com/kolide/launcher/ee/consoleuser.CurrentUsers

ee/control/client_http.go Fixed Show fixed Hide fixed
@RebeccaMahany RebeccaMahany force-pushed the becca/traces-for-potential-slow-spots branch 2 times, most recently from 0e7de03 to 287e954 Compare January 22, 2025 22:25
@RebeccaMahany RebeccaMahany force-pushed the becca/traces-for-potential-slow-spots branch from 287e954 to 1f973b1 Compare January 22, 2025 22:37
@RebeccaMahany RebeccaMahany marked this pull request as ready for review January 23, 2025 17:51
ee/control/control.go Outdated Show resolved Hide resolved
Copy link
Contributor

@zackattack01 zackattack01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 looks great, thank you!

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Jan 23, 2025
Merged via the queue into kolide:main with commit 5453166 Jan 23, 2025
32 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/traces-for-potential-slow-spots branch January 23, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants