add tracing to all allowed cmds #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
commented
Jan 23, 2025
James-Pickett
commented
Jan 23, 2025
| func execFaker(filename string) func(context.Context, ...string) (*exec.Cmd, error) { | ||
| return func(ctx context.Context, _ ...string) (*exec.Cmd, error) { | ||
| return exec.CommandContext(ctx, "/bin/cat", filename), nil //nolint:forbidigo // Fine to use exec.CommandContext in test | ||
| func execFaker(filename string) func(context.Context, ...string) (*allowedcmd.TracedCmd, error) { |
There was a problem hiding this comment.
the method is the reason I had to export allowedcmd.TracedCmd
James-Pickett
commented
Jan 23, 2025
James-Pickett
commented
Jan 23, 2025
James-Pickett
changed the title
zackattack01
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embeds our allowed commands in a TracedCmd struct to start a span when ever we exec.