Add wrapper to enforce timeout for extension tables #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
36
to
37
| // Kick off running the query | ||
| resultChan := make(chan *generateResult) |
There was a problem hiding this comment.
I love that this has the effect is interrupting no matter what's happening. But I'm also slightly leery of these piling up. Is there any way to clean this up? I assume not. So maybe we need to add something only spawn one generate (per table) at a time?
There was a problem hiding this comment.
Discussed offline -- I will add some limits in a follow-up PR
RebeccaMahany
force-pushed
the
becca/table-timeouts
branch
from
b153a65 to
5f838a0
Compare
cesarfda
previously approved these changes
Jan 30, 2025
RebeccaMahany
force-pushed
the
becca/table-timeouts
branch
from
96c454b to
0f1f2b7
Compare
James-Pickett
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tablewrapperpackage to ensure that osquery does not ever have to wait on a call togeneratefor more than four minutes by default