Pass proto root and proto file to grpc.load #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a small change to pass proto root and proto file to
grpc.load()
, allowing for correct inclusion of additional protobuf files.The interface becomes the following:
This allows us to do something like this in our service definitions, assuming that the imported proto files are available in the path provided when calling the above function:
Unfortunately this isn't the cleanest pull request - I haven't had a chance to get the tests working because I can't seem to get them running on my machine. I also had to use Node v7.10.1 and NPM v4.2.0 and make some tweaks to package.json to get the thing building (there was a
yarn.lock
but notpackage-json.lock
inmaster
).Getting this fork to a mergeable state shouldn't require much more effort, but I don't want to spend much time on it if there's not any interest in merging it.