Skip to content

Commit

Permalink
Merge pull request #42 from konecty/fix/konecty-erros
Browse files Browse the repository at this point in the history
Fix: parse konecty errors
  • Loading branch information
silveirado authored Feb 6, 2024
2 parents 9d7c3aa + dbb94b8 commit 7217e52
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/sdk/Module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { History, KonectyClient, KonectyClientOptions, KonectyFindResult } from
import { MetadataField, MetadataLabel } from '@konecty/sdk/types/metadata';
import get from 'lodash/get';
import 'reflect-metadata';
import parseKonectyErrors from 'utils/parseErrors';
import { FieldOperators } from './FieldOperators';
import { ArrElement, Nullable, PickFromPath, UnionToIntersection } from './TypeUtils';
import { User } from './User';
Expand Down Expand Up @@ -168,7 +169,7 @@ export class KonectyModule<
return null;
}

throw new Error(result.errors?.join('\n') ?? 'Unknown error');
throw new Error(parseKonectyErrors(result.errors ?? ['Unknown error']));
}

async find(
Expand All @@ -194,7 +195,7 @@ export class KonectyModule<
count: result.total as number,
};
}
throw new Error(result.errors?.join('\n') ?? 'Unknown error');
throw new Error(parseKonectyErrors(result.errors ?? ['Unknown error']));
}

async getHistory(_id: string): Promise<FindResult<History>> {
Expand All @@ -206,7 +207,7 @@ export class KonectyModule<
count: result.total as number,
};
}
throw new Error(result.errors?.join('\n') ?? 'Unknown error');
throw new Error(parseKonectyErrors(result.errors ?? ['Unknown error']));
}

// #endregion
Expand Down Expand Up @@ -280,7 +281,7 @@ export class KonectyModule<
total: result.total as number,
};
}
throw new Error(result.errors?.join('\n') ?? 'Unknown error');
throw new Error(parseKonectyErrors(result.errors ?? ['Unknown error']));
}
// #endregion

Expand Down
5 changes: 5 additions & 0 deletions src/utils/parseErrors.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type KonectyErrors = string[] | { message: string }[];

export default function parseKonectyErrors(err: KonectyErrors) {
return err.map(err => (typeof err === 'string' ? err : err.message)).join('\n');
}

0 comments on commit 7217e52

Please sign in to comment.