[야구] 노민정 미션 제출합니다 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
수정해야할 내용 : start()에서 computer에 null값이 들어감
khyojun
reviewed
Nov 26, 2022
| if (!userInput.matches(IS_NUMBER)) { | ||
| throw new IllegalArgumentException("[ERROR]" + CHECK_STRING); | ||
| } | ||
| int size = Integer.parseInt(userInput); |
There was a problem hiding this comment.
size를 변환을 하셔야하는데 입력값이 size로 들어갔습니다.
jiggyjiggy
reviewed
Nov 27, 2022
|
|
||
| public static final int INPUT_LENGTH = 3; | ||
|
|
||
| public static final String IS_NUMBER = "[0-9]*"; |
|
|
||
| import java.util.List; | ||
|
|
||
| public class Compare { |
|
|
||
| import static java.util.stream.Collectors.toList; | ||
|
|
||
| public class CreateNumber { |
There was a problem hiding this comment.
클래스 네이밍 컨벤션에는 NumberCreator가 적절해 보입니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.