Merge branch 'develop' into upload-fixes

.nvmrc

@@ -0,0 +1 @@
+18

README.md

@@ -107,6 +107,22 @@ JOBS_USERNAME=jobuser
 JOBS_PASSWORD=jobpassword
 ```
 
-## Usage in tests
+## Publishing New Version
 
-## Contribute
+Create a branch that doesn't have the same name as the tag e.g. NOT v1.0.120
+
+```
+git checkout <some_name>
+```
+
+Increase the version
+
+```
+npm version patch
+```
+
+Push the changes with tags
+
+```
+git push --follow-tags
+```

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kontist/mock-solaris",
-  "version": "1.0.118",
+  "version": "1.0.123",
   "description": "Mock Service for Solaris API",
   "main": "dist/src/index.js",
   "types": "dist/src/index.d.ts",

src/db.ts

@@ -231,7 +231,7 @@ export const getPerson = async (personId: string): Promise<MockPerson> => {
   return augmentPerson(person);
 };
 
-export const removePerson = async (personId: string): Promise<MockPerson> => {
+export const removePerson = async (personId: string) => {
   const person = await getPerson(personId);
   const score = moment(person.createdAt).valueOf();
   const key = `${process.env.MOCKSOLARIS_REDIS_PREFIX}:persons`;

src/helpers/webhooks.ts

@@ -63,6 +63,8 @@ const WEBHOOK_SECRETS = {
     process.env.SOLARIS_PERSON_DELETED_WEBHOOK_SECRET,
   [PersonWebhookEvent.PERSON_CHANGED]:
     process.env.SOLARIS_PERSON_CHANGED_WEBHOOK_SECRET,
+  [PersonWebhookEvent.QUESTIONS_REQUIRE_RESPONSE]:
+    process.env.SOLARIS_QUESTIONS_REQUIRE_RESPONSE_WEBHOOK_SECRET,
 
   [TransactionWebhookEvent.BOOKING]: process.env.SOLARIS_BOOKING_WEBHOOK_SECRET,
   [TransactionWebhookEvent.SEPA_SCHEDULED_TRANSACTION]:

src/routes/backoffice.ts

@@ -282,10 +282,11 @@ export const updatePersonHandler = async (req, res) => {
   }
 
   let questionSet = null;
-  const shouldGenerateQuestionSet = [
-    req.body.customer_vetting_status,
-    req.body.risk_classification_status,
-  ].includes(CustomerVettingStatus.INFORMATION_REQUESTED);
+  const shouldGenerateQuestionSet =
+    req.body.customerVettingStatus ===
+      CustomerVettingStatus.INFORMATION_REQUESTED ||
+    req.body.riskClassificationStatus ===
+      RiskClarificationStatus.INFORMATION_REQUESTED;
 
   if (shouldGenerateQuestionSet) {
     questionSet = await createQuestionSet(person.id);
@@ -305,7 +306,10 @@ export const updatePersonHandler = async (req, res) => {
   if (questionSet) {
     await triggerWebhook({
       type: PersonWebhookEvent.QUESTIONS_REQUIRE_RESPONSE,
-      payload: questionSet,
+      payload: {
+        question_set_id: questionSet.id,
+        ...questionSet,
+      },
       personId: person.id,
     });
   }

src/routes/persons.ts

@@ -1,6 +1,7 @@
 import _ from "lodash";
 import moment, { Moment } from "moment";
 import type { Request, Response } from "express";
+import HttpStatusCodes from "http-status";
 
 import {
   getPerson,
@@ -73,8 +74,8 @@ export const createPerson = async (req, res) => {
 export const deletePerson = async (req, res) => {
   const { id: personId } = req.params;
   try {
-    const isPersonDeleted = await removePerson(personId);
-    return res.status(200).send(isPersonDeleted);
+    await removePerson(personId);
+    res.sendStatus(HttpStatusCodes.NO_CONTENT);
   } catch (err) {
     return res.status(500).send({
       errors: [

tests/routes/backoffice.spec.ts

@@ -135,8 +135,7 @@ describe("Backoffice", () => {
         const req = mockReq({
           params: { id: "personId" },
           body: {
-            customer_vetting_status:
-              CustomerVettingStatus.INFORMATION_REQUESTED,
+            customerVettingStatus: CustomerVettingStatus.INFORMATION_REQUESTED,
           },
         });
         const res = mockRes();
@@ -162,7 +161,7 @@ describe("Backoffice", () => {
         const req = mockReq({
           params: { id: "personId" },
           body: {
-            risk_classification_status:
+            riskClassificationStatus:
               RiskClarificationStatus.INFORMATION_REQUESTED,
           },
         });