Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add static-report capability to kantra for .net framework #271

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

djzager
Copy link
Member

@djzager djzager commented Jun 26, 2024

Fixes #265
Fixes #270

@djzager
Copy link
Member Author

djzager commented Jun 26, 2024

hold until konveyor/analyzer-lsp#629

//}
if a.bulk {
err := fmt.Errorf("Unsupported option")
a.log.Error(err, "Bulk analysis not supported for .NET Framework projects")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq for my own learning: why can't it support the bulk option?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing what was happening in GenerateStaticReport for handling bulk analysis, specifically the moveResults and copyFileContents...I got scared about what could be broken.

#272

Also adds windows container build to image build workflow.

Signed-off-by: David Zager <[email protected]>
@djzager djzager merged commit 9c39da9 into konveyor:main Jun 26, 2024
3 checks passed
aufi pushed a commit to aufi/kantra that referenced this pull request Jul 16, 2024
…#271)

Also adds windows container build to image build workflow.

Signed-off-by: David Zager <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Kantra Image for Windows is not being generated [BUG] .NET Framework Provider (Windows Only Issues)
2 participants