Skip to content

Commit

Permalink
Fix : 버그수정 및 불필요한 에러코드 제거
Browse files Browse the repository at this point in the history
  • Loading branch information
begong313 committed May 26, 2024
1 parent 7210af0 commit 92e9460
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public ResponseEntity<?> uploadBetweenResult(
Long id = encryptionService.extractIdFromToken(authorization);
// between 단계가 아니면 요청을 보낼 수 없음. 현재 테스트를 위해 빼놓은 상태
Step stepCheck = missingPeopleService.getStep(id, false).getStep();
if (stepCheck.equals(Step.fromValue("between"))) {
if (!stepCheck.equals(Step.fromValue("between"))) {
throw new CustomException(ErrorCode.BAD_REQUEST, "invalid step", "can't request step");
}
//상화작용 단계 결과 db저장
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public MissingPeopleForGuardianDto getMissingPeople(Long id) {
public void postBetween(Long id, BetweenRequestDto betweenRequestDto) {
try {
MissingPeopleEntity missingPeopleEntity = missingPeopleRepository.findById(id)
.orElseThrow(() -> new NoSuchElementException("Missing person not found with ID: " + id));
.orElseThrow(() -> new NoSuchElementException("Missing person not found with ID " ));
SearchResultEntity searchResultEntity = null;
for (Long resultId : betweenRequestDto.getResultIds()) { //TODO : 반복문을 돌며 저장해 db호출이 너무많음. //유효성검사도 더 해야될듯
searchResultEntity = searchResultRepository.findById(resultId)
Expand Down

0 comments on commit 92e9460

Please sign in to comment.