Skip to content
This repository has been archived by the owner on Apr 17, 2024. It is now read-only.

docs: Cleaned up wording, added steps. #17

Closed
wants to merge 1 commit into from
Closed

Conversation

IanEff
Copy link
Contributor

@IanEff IanEff commented Jan 5, 2024

build:
busybot:
chore:
ci:
cd:
docs: setup-demo.md
feat:
fix:
flux:
perf:
refactor:
revert:
style:
test: manual runthrough

Copy link

linear bot commented Jan 5, 2024

@IanEff IanEff requested a review from zalsader January 5, 2024 23:05
@IanEff IanEff self-assigned this Jan 5, 2024
@IanEff IanEff added the documentation Improvements or additions to documentation label Jan 5, 2024
Copy link
Contributor

@zalsader zalsader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving this guide!

Why's the PR's root not the main branch?

Comment on lines +7 to +11
To follow this guide, you will need a Hetzner API token. To generate this you will need to:
- Sign in into the [Hetzner Cloud Console](https://console.hetzner.cloud/)
- Select your project
- Go to Security → API Tokens
- Generate a new token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we just use the one in 1password?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To answer the first question, I was messing around with forking in the VSCode interface, & mucked up the branch. Apologies!

As for the second, I believe this documentation is meant to be customer-facing at some point, so no need for the 1password stuff.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

@zalsader zalsader changed the base branch from docs/gen-290 to main January 15, 2024 18:02
@zalsader
Copy link
Contributor

Closed in favor of #19

@zalsader zalsader closed this Jan 15, 2024
@zalsader zalsader deleted the feature/gen-291 branch January 15, 2024 23:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants