fix: Handle unbalanced comment string

kordamp · Sep 26, 2024 · a0c4a0e · a0c4a0e
1 parent dc24879
commit a0c4a0e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/subprojects/json-lib-core/src/main/java/org/kordamp/json/util/JSONTokener.java b/subprojects/json-lib-core/src/main/java/org/kordamp/json/util/JSONTokener.java
@@ -203,6 +203,8 @@ public char nextClean() {
                             if (c == '*') {
                                 if (next() == '/') {
                                     break;
+                                } else if (!more()) {
+                                    return 0;
                                 }
                                 back();
                             }

diff --git a/subprojects/json-lib-core/src/test/java/org/kordamp/json/TestJSONSerializer.java b/subprojects/json-lib-core/src/test/java/org/kordamp/json/TestJSONSerializer.java
@@ -144,6 +144,15 @@ public void testToJava_JSONObject_4() {
         assertEquals(beanB.getValue(), ((ValueBean) bb).getValue());
     }
 
+    public void testToJava_JSONObject_5() throws Exception {
+        try {
+            JSONObject.fromObject("/**");
+            fail("Should have thrown a JSONException");
+        } catch (JSONException expected) {
+            // ok
+        }
+    }
+
     public void testToJava_JSONObject_and_reset() throws Exception {
         String json = "{bool:true,integer:1,string:\"json\"}";
         JSONObject jsonObject = JSONObject.fromObject(json);