Feature/bnayak negxfuboone #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which we see a fair bit in MicroBooNE. this fixes bug esp in nuc-A where ppfx assigned 0% uncertainty to such events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issues this PR addresses is :
It does this by extending the number of bins for the MesonIncident reweighter to 8 in total, going from (-1, 1) instead of (0, 1) before and applying a correlated 40% + uncorrelated 40% across the negative xF bins.
This is the current implementation of PPFX in MicroBooNE with the extra addition of the changes in this PR. This should have a sizeable impact on very off-axis NuMI experiments but negligible for on-axis/nearly on-axis NuMI experiments.
More details are given in the talk to the PPFX WG here