update FFI C declarations #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update & fix `pthread_cond_t` / `pthread_mutex_t` declarations: correct layout for 64bits - fix `ANativeActivity` declaration: add missing `obbPath` field (since Android 3 [HoneyComb]) - cleanup, reduce differences with NDK headers
NiLuJe
approved these changes
Aug 28, 2024
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Aug 30, 2024
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pthread_cond_t/pthread_mutex_tdeclarations: correct layout for 64bitsANativeActivitydeclaration: add missingobbPathfield (since Android 3 [HoneyComb])No real impact that I could see:
android_appstructure creation in Lua code, no access "below" theandroid_app.configfield (before the "private" fields, including thepthread_cond_t/pthread_mutex_tone)ANativeActivitystructure creation in Lua code, missing field was lastThis change is