ffi/pthread: fix pthread_attr_t and PTHREAD_CREATE_DETACHED declarations
#1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rations The declarations of `pthread_attr_t` and `PTHREAD_CREATE_DETACHED` depend on the arch / OS: | Target machine | `sizeof (pthread_attr_t)` | `PTHREAD_CREATE_DETACHED` | |---------------------------------|--------------------------:|--------------------------:| | aarch64-linux-gnu-g++ | 64 | 1 | | aarch64-unknown-linux-android21 | 56 | 1 | | arm-kindlepw2-linux-gnueabi | 36 | 1 | | arm-linux-gnueabihf | 36 | 1 | | arm64-apple-darwin23.6.0 | 64 | 2 | | armv7a-unknown-linux-android18 | 24 | 1 | | i386-pc-linux-gnu | 36 | 1 | | i686-unknown-linux-android18 | 24 | 1 | | x86_64-apple-darwin22.6.0 | 64 | 2 | | x86_64-pc-linux-gnu | 56 | 1 | The following C++ compiler command can be used to print those values: ```bash ▸ g++ -x c++ -c -o /dev/null - <<\EOF template <int val> struct PrintConst; PrintConst<sizeof (pthread_attr_t)> sizeof_pthread_attr_t; PrintConst<PTHREAD_CREATE_DETACHED> valueof_PTHREAD_CREATE_DETACHED; EOF <stdin>:3:37: error: aggregate ‘PrintConst<56> sizeof_pthread_attr_t’ has incomplete type and cannot be defined <stdin>:4:37: error: aggregate ‘PrintConst<1> valueof_PTHREAD_CREATE_DETACHED’ has incomplete type and cannot be defined ```
Frenzie
approved these changes
Oct 5, 2024
NiLuJe
approved these changes
Oct 5, 2024
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The declarations of
pthread_attr_tandPTHREAD_CREATE_DETACHEDdepend on the arch / OS:sizeof (pthread_attr_t)PTHREAD_CREATE_DETACHEDThe following C++ compiler command can be used to print those values:
Previous declarations were wrong on aarch64-linux, armv7a-android, i686-android, and macOS.
This change is