-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update setup-ghidra #42
Conversation
f910283
to
03e40ff
Compare
I'm not so sure about passing GH token just to download Ghidra. |
That is optional. You may not pass it but if you run a lot of jobs consecutively you may hit API rate limiting. I will remove it. If you ever hit API rate limiting it is just a matter of adding it back. :) |
03e40ff
to
bf64d34
Compare
Done :) |
Thanks, I've never hit limits with the old plugins so I'd rather avoid it. |
Oh, it is not intended to be mandatory but I always pass the token. This is useful testing for me. I will find some time to look into it, fix it and get back to the PR. I will mark as a draft for the time being. Thanks for the patience! |
bf64d34
to
fb269ce
Compare
Found some time to do this :) |
Awesome looks like it works now. Can you update the publish workflow too? |
fb269ce
to
c54804e
Compare
Oops. Done! BTW, you may be able to condense both files into one by using an "if" parameter in the publish step to check for tag pushes... :) |
Thanks! Yeah, that's a good idea, I'll look into it. |
No description provided.