Remove dependency on deprecated conventions API #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Project.convention` and other conventions API methods have been deprecated and will be removed in Gradle 9.0. To make things worse, the `Project.convention.plugins["java"]` does not return `DefaultJavaPluginConvention` anymore, but instead returns a wrapper class that issues deprecation warnings. Since the plugin cannot find the expected class, it stopped working properly (this is probably the cause of kotest#53). This pull requests simply replaces the single use of `Project.convention.plugins[]` (finding the Java test sourceset) with `Project.extensions.findByType`. Fixes: kotest#42, kotest#53
|
awesome thanks |
|
@sksamuel just quick question - when new release will came out, including this patch? |
|
Yep this is in the latest release.
…On Mon, Jan 1, 2024, 6:08 PM Roeniss Moon ***@***.***> wrote:
@sksamuel <https://github.com/sksamuel> just quick question - when new
release will came out, including this patch?
—
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVSGTFQ6YT46XAE4ZNRXTYMNFX5AVCNFSM6AAAAABBD3KAWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZTGUZTMMRZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sorry but which version do you mean? I see 0.4.0 only on release page |
|
0.4.11 https://plugins.gradle.org/plugin/io.kotest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project.conventionand other conventions API methods have been[deprecated](https://docs.gradle.org/current/userguide/upgrading_version_7.html#all_convention_deprecation] and will be removed in Gradle 9.0. To make things worse, the
Project.convention.plugins["java"]does not returnDefaultJavaPluginConventionanymore, but instead returns a wrapperclass that issues deprecation warnings. Since the plugin cannot find the
expected class, it stopped working properly (this is probably the cause
of #53).
This pull requests simply replaces the single use of
Project.convention.plugins[](finding the Java test sourceset) withProject.extensions.findByType.Fixes: #42, #53