Tweak implementation of cl_arm_printf and introduce dedicated test fixture #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xture Change-Id: Ib27b60fb043e47227f519f34e04316d04f47b55d
rjodinchr
reviewed
Aug 29, 2024
| if (buff_size_prop_index != -1 && !config.printf_buffer_size.set) { | ||
| m_printf_buffersize = m_properties[buff_size_prop_index]; | ||
| } else { | ||
| m_printf_buffersize = config.printf_buffer_size; | ||
| m_printf_buffersize = 0; |
There was a problem hiding this comment.
I think it m_printf_buffersize really needs to be initialize with config.printf_buffer_size().
There was a problem hiding this comment.
I changed the getter so the buffer size is taken from the config if it wasn't provided via the extension. This works for test overrides. It adds a bit of complexity but I think it's worth it for the benefits on the test side.
rjodinchr
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ib27b60fb043e47227f519f34e04316d04f47b55d