KB-85 Main and other static pages #335
Conversation
| </Paragraph> | ||
| </div> | ||
| <div className="hidden grow basis-0 xl:block"> | ||
| <Image src="/images/Saly-10.png" width={482} height={422} alt="saly" className="he-full w-full" /> |
There was a problem hiding this comment.
The quality of image will be not that good by default. Set quality=100.
Checkout https://nextjs.org/docs/pages/api-reference/components/image#quality
There was a problem hiding this comment.
This is just a temporary dummy picture, but if you insist...
tailwind.config.js
Outdated
There was a problem hiding this comment.
unused variable defaultTheme
|
|
||
| export const metadata: Metadata = { | ||
| title: "Sign-In", | ||
| title: 'Sign-In', |
There was a problem hiding this comment.
Hardcoded English title
src/hooks/use-is-client.tsx
Outdated
There was a problem hiding this comment.
Where you are using it?
There was a problem hiding this comment.
Currently nowhere, but if you remember I used it in one of the client components that utilized localStorage. I'll leave it here for now.
|
|
||
| export default function ComplaintsPage() { | ||
| const t = useTranslations(INTL_NAMESPACE); | ||
| const conttactsT = useTranslations('private.contacts'); |
There was a problem hiding this comment.
Misspelling in variables name :)
| <div className="flex items-center justify-between bg-basic-white h-[80px] px-6"> | ||
| <SidebarTrigger /> | ||
| <header className="sticky top-0 flex h-[80px] items-center justify-between bg-basic-white px-6"> | ||
| <div>{isMobile && <SidebarTrigger />}</div> |
There was a problem hiding this comment.
You don't need to wrap button in empty div to make justify-between style work for desktop screens and actually you don't need to use hook to hide SidebarTrigger for mobiles. You can do it with simple tailwind styles.
There was a problem hiding this comment.
useIsMobile is a hook that came with shadcn sidebar component, and it's used there. If I'll use CSS breakpoints in this place, they may mismatch with a breakpoint value of the one in useIsMobile and therefore with a sidebar itself. Fort this reason I wrapped it in a div, so justify-between will work in both cases.
I won't get rid of useIsMobile here, but I'll do it in a bit different way if that bugs you.
src/messages/uk.json
Outdated
| "contacts": { | ||
| "title": "Контакти", | ||
| "header": "Контакти", | ||
| "content": "<h3>Контактнi данi</h3><p>Адреса констуркторського бюро: <addresslink>Україна, м. Київ, вул. Політехнічна 14-в</addresslink>, корпус 13, 4 поверх, 25 кабінет</p><h3>Соцiальнi мережi</h3><p><githublink>КПI у GitHub</githublink><br></br><facebooklink>Facebook</facebooklink><br></br><twitterlink>Twitter</twitterlink><br></br><instagramlink>Instagram</instagramlink><br></br></p><h3>Служба підтримки</h3><p>Якщо у вам є питання, ви можете звернутися до служби підтримки:</p><complaintslink>Форма скарг i пропозицiй</complaintslink><br></br><emaillink>Email</emaillink>" |
There was a problem hiding this comment.
error in word "констуркторського"
There was a problem hiding this comment.
error in "Якщо у вам є питання"
|
@a-gubskiy changes were not resolved why you are requesting a review? |
|
I thought that it was already fixed. Maybe messed up some GitHub notification in my mailbox |
No description provided.