KB-187 implement profile page #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markusplay
force-pushed
the
KB-187-Implement-profile-page
branch
4 times, most recently
from
03064bc to
414085a
Compare
Markusplay
force-pushed
the
KB-187-Implement-profile-page
branch
from
414085a to
f001707
Compare
Markusplay
force-pushed
the
KB-187-Implement-profile-page
branch
from
92328a6 to
a2d415a
Compare
Markusplay
force-pushed
the
KB-187-Implement-profile-page
branch
from
d6bc73d to
1abff05
Compare
Markusplay
force-pushed
the
KB-187-Implement-profile-page
branch
from
1abff05 to
6e18fe1
Compare
Markusplay
force-pushed
the
KB-187-Implement-profile-page
branch
from
3396bf4 to
a26e368
Compare
# Conflicts: # src/messages/en.json # src/messages/uk.json
Markusplay
force-pushed
the
KB-187-Implement-profile-page
branch
3 times, most recently
from
8da38f0 to
c130969
Compare
Markusplay
force-pushed
the
KB-187-Implement-profile-page
branch
from
c130969 to
efcb7ba
Compare
niravzi
requested changes
Jan 10, 2025
| return ( | ||
| <div className="flex flex-col gap-4"> | ||
| {employeeInfo.map((item, index) => ( | ||
| <div key={index} className="flex flex-col gap-3 md:flex-row md:gap-6"> |
There was a problem hiding this comment.
These next 3 divs with paragraphs have the same structure and classes. Maybe create a separate component?
There was a problem hiding this comment.
Also 170px looks a bit weird. Try making a more adaptive layout. It's already seen how social link doesn't fit properly.
src/app/[locale]/(private)/profile/components/intellect-agreement.tsx
Outdated
Show resolved
Hide resolved
src/app/[locale]/(private)/profile/components/contact-editor.tsx
Outdated
Show resolved
Hide resolved
src/app/[locale]/(private)/profile/components/fullname-english.tsx
Outdated
Show resolved
Hide resolved
src/app/[locale]/(private)/profile/components/intellect-publication-info.tsx
Show resolved
Hide resolved
| return ( | ||
| <div className="flex flex-col gap-4"> | ||
| {studentInfo.map((item, index) => ( | ||
| <div key={index} className="flex flex-col gap-3 md:flex-row md:gap-6"> |
There was a problem hiding this comment.
It's the same div and paragraph as in lecturer-info.
See, this w-[170px] must be defined only in one place eventually.
Markusplay
force-pushed
the
KB-187-Implement-profile-page
branch
4 times, most recently
from
5e1ac5f to
d64b9d9
Compare
Markusplay
force-pushed
the
KB-187-Implement-profile-page
branch
from
d64b9d9 to
66af650
Compare
niravzi
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.